Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move apply_patches from hooks to sync.js #3916

Closed
wants to merge 1 commit into from
Closed

Move apply_patches from hooks to sync.js #3916

wants to merge 1 commit into from

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Mar 27, 2019 •
edited
Loading

address #3915
require brave/brave-core#2102

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Requested a security/privacy review as needed.

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

@darkdh darkdh requested a review from bridiver March 27, 2019 23:54
@darkdh darkdh requested a review from bbondy March 28, 2019 00:01
@darkdh darkdh force-pushed the apply_patches branch 3 times, most recently from 6943606 to e4cfdc6 Compare March 28, 2019 01:41
bridiver
bridiver previously approved these changes Mar 28, 2019
View reviewed changes
@darkdh
Copy link
Member Author

darkdh commented Apr 3, 2019

cherry-picked into #3931

@darkdh darkdh closed this Apr 3, 2019
@darkdh darkdh mentioned this pull request Apr 3, 2019
Closed
@darkdh darkdh deleted the apply_patches branch April 3, 2019 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bridiver bridiver bridiver left review comments

@bbondy bbondy Awaiting requested review from bbondy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darkdh @bridiver